utils/bind-data-test-attributes: Handle failing set() with assert instead of warning
#205
Conversation
mathieupoteriepeopledoc
changed the title
set() with assert instead of warning
|
looks like CI is failing |
|
@Turbo87 I will take a look this afternoon. It was working locally. :) |
|
I updated the PR, in order to pass the test for every ember versions. I keep working on it and will let you know when I found a satisfying solution. |
|
@Turbo87 , the CI is failing, but on the same stage than the other PR (in the ember-release scenario). A colleague and I try to investigate on this issue. If we find anything, we will let you know. |
|
@mathieupoteriepeopledoc CI should be fixed now. can you rebase your changes on top of |
mathieupoteriepeopledoc
force-pushed
the
set_assert
branch
from
d1c9af0 to
fd08e65
Compare
|
|
||
| import bindDataTestAttributes from 'ember-test-selectors/utils/bind-data-test-attributes'; | ||
|
|
||
| module('Unit | Utility | bind data test attributes'); | ||
|
|
||
| test('it adds missing attributeBindings array', function(assert) { | ||
| let Fixture = EmberObject.extend({ | ||
| 'data-test-from-factory': 'foo', | ||
| 'data-test-from-factory': 'foo' |
There was a problem hiding this comment.
can you remove these unrelated changes? the PR should only contain the changed functionality. Styling changes should be proposed in a seperate PR.
mathieupoteriepeopledoc
force-pushed
the
set_assert
branch
2 times, most recently
from
1465c25 to
ca673f5
Compare
mathieupoteriepeopledoc
force-pushed
the
set_assert
branch
2 times, most recently
from
bc48d18 to
ad03823
Compare
|
@Turbo87, this is fixed, and git history of this PR has been cleaned. |
| let Fixture = EmberObject.extend({ | ||
| tagName: '', | ||
| 'data-test-from-factory': 'foo', | ||
| if (!config.stripTestSelectors) { |
There was a problem hiding this comment.
I don't understand this. Why are you checking config.stripTestSelectors here? The bindDataTestAttributes() function doesn't seem to care about that config option 🤔
mathieupoteriepeopledoc
force-pushed
the
set_assert
branch
from
ad03823 to
6014bf7
Compare
mathieupoteriepeopledoc
force-pushed
the
set_assert
branch
from
6014bf7 to
f9be194
Compare
|
@Turbo87 , sorry it was some code remaining from an integration test made previously. |
Wrote an integration test in order to test that the error is thrown when a data-test attribute is set on a tagless component.
close #204