utils/bind-data-test-attributes: Handle failing set() with assert i…

…nstead of warning (#205)

* utils/bind-data-test-attributes: Handle failing  with assert instead of warning

* Replaces integration tests with unit tests

addon/utils/bind-data-test-attributes.js

@@ -1,4 +1,4 @@
-import { warn } from '@ember/debug';
+import { assert, warn } from '@ember/debug';
 import { isArray } from '@ember/array';
 
 const TEST_SELECTOR_PREFIX = /data-test-.*/;
@@ -16,16 +16,13 @@ export default function bindDataTestAttributes(component) {
   }
 
   let tagName = component.get('tagName');
-  if (tagName === '') {
-    let message = `ember-test-selectors could not bind data-test-* properties on ${component} ` +
-      `automatically because tagName is empty.`;
 
-    warn(message, false, {
-      id: 'ember-test-selectors.empty-tag-name',
-    });
+  let message = `ember-test-selectors could not bind data-test-* properties on ${component} ` +
+    `automatically because tagName is empty.`;
 
-    return;
-  }
+  assert(message, tagName !== '', {
+    id: 'ember-test-selectors.empty-tag-name',
+  });
 
   let attributeBindings = component.getWithDefault('attributeBindings', []);
   if (!isArray(attributeBindings)) {

tests/unit/utils/bind-data-test-attributes-test.js

@@ -119,7 +119,7 @@ test('it skips if attributeBindings is a computed property', function(assert) {
   assert.deepEqual(instance.get('attributeBindings'), ['foo']);
 });
 
-test('it skips if tagName is empty', function(assert) {
+test('it breaks if tagName is empty', function(assert) {
   let Fixture = EmberObject.extend({
     tagName: '',
     'data-test-from-factory': 'foo',
@@ -128,9 +128,5 @@ test('it skips if tagName is empty', function(assert) {
     'data-test-from-invocation': 'bar',
   });
 
-  assert.deepEqual(instance.get('attributeBindings'), undefined);
-
-  bindDataTestAttributes(instance);
-
-  assert.deepEqual(instance.get('attributeBindings'), undefined);
+  assert.throws(() => bindDataTestAttributes(instance));
 });