-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module names #153
Module names #153
Conversation
I tried to run the laguna_del_maule notebook, but due to your changes this doesn't work either, I think. If you can do it, all you have to do is to put these lines after the inversion:
This will generate you a new archive, which you can upload then instead of the existing. |
The error I get, in case that helps you:
Edit: So maybe these changes affect more examples than you thought... |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
===========================================
- Coverage 82.1% 69.14% -12.97%
===========================================
Files 23 20 -3
Lines 4974 4028 -946
===========================================
- Hits 4084 2785 -1299
- Misses 890 1243 +353
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
===========================================
- Coverage 82.1% 69.14% -12.97%
===========================================
Files 23 20 -3
Lines 4974 4028 -946
===========================================
- Hits 4084 2785 -1299
- Misses 890 1243 +353
Continue to review full report at Codecov.
|
Closed as it was superseded by #227 |
Todos:
shelve
is not unpacking correctly because of this change. @prisae, would you be willing to help update this example?