Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module 'request-logs' #88

Closed
ifedapoolarewaju opened this issue Mar 14, 2018 · 4 comments
Closed

Cannot find module 'request-logs' #88

ifedapoolarewaju opened this issue Mar 14, 2018 · 4 comments

Comments

@ifedapoolarewaju
Copy link

after updating to the latest version of grant.js on uppy-server, I am getting the following error.

screen shot 2018-03-15 at 12 07 49 am

is this expected? Should request-logs be installed as a dependency?

@simov
Copy link
Owner

simov commented Mar 14, 2018

Do you have any environment variables set? This dependency should be needed only when the DEBUG environment variable is set. I should probably remove it anyway as it can cause issues.

@ifedapoolarewaju
Copy link
Author

ifedapoolarewaju commented Mar 14, 2018

I am setting export DEBUG="to some value", but I think this implicit behaviour might be undesirable since the env variable set might be unrelated with the library(request-compose). Especially since request-logs is set as a devDependency.

@simov
Copy link
Owner

simov commented Mar 14, 2018

Yep, I'll change that, I'll let you know once it's ready.

@simov
Copy link
Owner

simov commented Mar 15, 2018

@ifedapoolarewaju I've published v4.0.1 you should be able to remove the request-logs dependency now.

Thanks for the feedback 👍

Let me know if you find anything else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants