transfer-encoding: chunked for DB downloads, refs #749

This should get >32MB downloads working on Cloud Run.
simonw · Dec 2, 2020 · 88ac538 · 88ac538
1 parent a970276
commit 88ac538
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/datasette/views/database.py b/datasette/views/database.py
@@ -169,6 +169,7 @@ async def view_get(self, request, database, hash, correct_hash_present, **kwargs
         headers = {}
         if self.ds.cors:
             headers["Access-Control-Allow-Origin"] = "*"
+        headers["Transfer-Encoding"] = "chunked"
         return AsgiFileDownload(
             filepath,
             filename=os.path.basename(filepath),

diff --git a/tests/test_html.py b/tests/test_html.py
@@ -1028,6 +1028,7 @@ def test_database_download_for_immutable():
             download_response.headers["content-disposition"]
             == 'attachment; filename="fixtures.db"'
         )
+        assert download_response.headers["transfer-encoding"] == "chunked"
 
 
 def test_database_download_disallowed_for_mutable(app_client):