Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS240 Acquisition Crashed without Killing Agent #165

Open
kmharrington opened this issue May 11, 2021 · 1 comment
Open

LS240 Acquisition Crashed without Killing Agent #165

kmharrington opened this issue May 11, 2021 · 1 comment
Labels
agent: ls240 bug Something isn't working
Milestone

Comments

@kmharrington
Copy link
Member

We had one of our LS240s crashbut the agent stayed up and showed now errors. Here's a cutout of the logs.

Restarting the agent got readout back, but an OCS status monitor wouldn't have caught it.

2021-05-10T15:42:36+0000 acq:1 Status is now "running".
2021-05-11T16:56:55+0000 acq:1 Crash in thread: [Failure instance: Traceback: <class 'TimeoutError'>: Device timed out
/usr/lib/python3.6/threading.py:916:_bootstrap_inner
/usr/lib/python3.6/threading.py:864:run
/usr/local/lib/python3.6/dist-packages/twisted/_threads/_threadworker.py:46:work
/usr/local/lib/python3.6/dist-packages/twisted/_threads/_team.py:190:doWork
--- <exception caught here> ---
/usr/local/lib/python3.6/dist-packages/twisted/python/threadpool.py:250:inContext
/usr/local/lib/python3.6/dist-packages/twisted/python/threadpool.py:266:<lambda>
/usr/local/lib/python3.6/dist-packages/twisted/python/context.py:122:callWithContext
/usr/local/lib/python3.6/dist-packages/twisted/python/context.py:85:callWithContext
LS240_agent.py:250:start_acq
/app/socs/socs/Lakeshore/Lakeshore240.py:280:get_reading
/app/socs/socs/Lakeshore/Lakeshore240.py:114:msg
]
2021-05-11T16:56:55+0000 acq:1 Status is now "done".
@jlashner
Copy link
Collaborator

Though not exactly the same, I think this is similar enough to #7 and #128. I think it just boils down to how we want to handle disconnects. I think the acq function should probably attempt to re-initialize the ls240 module before crashing, and then if that doesn't work just killing the reactor entirely instead of leaving the agent running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent: ls240 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants