Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lakeshore240 agents should not quit the acq process when disconnected #534

Open
jlashner opened this issue Sep 28, 2023 · 1 comment
Open

Comments

@jlashner
Copy link
Collaborator

Currently if a lakeshore240 loses connection, the ls240 module object loses connection, and the acq process crashes. It is currently impossible to re-initialize the object with the initialize task, since the agent will think it's already initialized and exit out:

if self.initialized:
return True, "Already Initialized Module"

I think we should make the changes I made to the vantage agent here (https://github.com/simonsobs/socs/pull/524/files), and have it so that if daq times out in the acq process, instead of crashing, it attempts to re-connect, and then waits for 30s or so. That way when it's plugged back in it will re-connect and continue acq right away.

@BrianJKoopman
Copy link
Member

Yeah, I'd like to try to standardize how agents handle dropped connections. I wrote up some thoughts here: #538

This relates to #165, and as you point out there, just comes down to how we want to handle disconnects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants