Fix healpix 'auto' tiling #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhasself
reviewed
Nov 6, 2024
src/Projection.cxx
Outdated
Comment on lines
599
to
603
| if (nside_tile > nside){ | ||
| std::ostringstream err; | ||
| err << "Invalid nside_tile " << nside_tile << " > nside " << nside; | ||
| throw ValueError_exception(err.str()); | ||
| } |
There was a problem hiding this comment.
Thanks, just fix the indentation (4-space), and add a space before the {.
'auto' nside_tile is capped to nside Add check that nside_tile <= nside in C++
earosenberg
force-pushed
the
fix-tiled-healpix
branch
from
8cd427e to
bb392eb
Compare
mhasself
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #190.
The 'auto' routine for setting the 'Healpix tiling now caps nside_tile to nside.
Add check that nside_tile <= nside in C++. If not it will raise a ValueError that can be passed back to Python instead of failing on a FloatingPointError.