-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hk resample #19
base: master
Are you sure you want to change the base?
Hk resample #19
Conversation
Finally, a version with basic functionality! It works on the HK [I haven't checked to ensure that I'm up-to-date on our python formatting guidelines, so please let me know if there is anything egregious that I should fix.] Currently you can do the following:
Bugs to fix:
|
The |
Yeah, it "fails" past a threshold. I bumped it to 3% when things were failing for any change at all. I do think some tests would be valuable to add. You mention it works on the test data on simons1. What was tested on each file set? Can those tests be added? Getting the data set into the test environment can be setup later. |
Resampler basically works now in in the I think it can be merged if we want. At the same time, there are still a few things to do/improve.
|
This adds a module for resampling data in a frame. Currently it is fairly skeletal, but just to show my basic idea for how to do this. In particular, comments welcome on:
scheme
is implemented).HKSessionHelper
)?