Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use map_set name to follow other script in the pipe, change a bit the… #46

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

thibautlouis
Copy link
Collaborator

… debug message

@thibautlouis thibautlouis requested a review from xgarrido February 3, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (afa4fc0) 19.33% compared to head (c531ecf) 19.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   19.33%   19.91%   +0.57%     
==========================================
  Files          15       15              
  Lines        1557     1557              
==========================================
+ Hits          301      310       +9     
+ Misses       1256     1247       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -129,5 +130,5 @@ def port2sacc(
log.info("Adding covariance")
s.add_covariance(cov)

log.info(f"Writing {sacc_file_name}")
log.info(f"Writing {sacc_file_name} \n")
Copy link
Collaborator

@xgarrido xgarrido Feb 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.info append \n why you want an additional \n ?

@thibautlouis thibautlouis merged commit c17ff1d into main Feb 4, 2024
16 checks passed
@xgarrido xgarrido deleted the minor_io_change branch April 1, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants