HostManager: use "docker compose" instead of "docker-compose" #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the "--docker-compose-bin" argument, which was never fully propagated, in any case (especially "up" and "down" were always run with whatever docker-compose was in the PATH); and "inspect" was (and continues to be) run with the default docker binary in PATH.
BrianJKoopman
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When managing docker containers, instead of using a mixture of calls to
dockeranddocker-composeCLIs, the code now exclusively usesdocker(through the "v2" interfacedocker compose ...).This work also removes the "--docker-compose-bin" argument, which was never fully propagated, in any case (especially "up" and "down" were always run with whatever docker-compose was in the PATH); and "inspect" was (and continues to be) run with the default docker binary in PATH.
Motivation and Context
Resolves #382
How Has This Been Tested?
Tested with a bunch of FakeDataAgents on system running Docker version 25.0.2.
Types of changes
Checklist: