Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split mflike #186

Merged
merged 18 commits into from
Sep 27, 2024
Merged

split mflike #186

merged 18 commits into from
Sep 27, 2024

Conversation

cmbant
Copy link
Collaborator

@cmbant cmbant commented Aug 2, 2024

Following #183, this attempts to remove mflike and use from LAT_MFlike (simonsobs/LAT_MFLike#86) as required.

Rather than inheriting GaussianLikelihood, LAT_MFlike just adds _get_theory and _get_gauss_data methods to interface with MultiGaussianLikelihood, which seems to be all that is needed. (though MultiGaussianLikelihood still does nothing... we should try some realistic test with lensing x lensed CMB)

Queries:

  • Did we need separate bandpass theory? (currently absorbed)
  • The delta chi2 in test_multi used to be very very small, why? (I've changed it, but don't know new value is correct)
  • There's a lot of duplicated text between developers.rst and theory-component-guidelines.rst.

@cmbant cmbant marked this pull request as ready for review August 2, 2024 16:00
@cmbant cmbant linked an issue Aug 2, 2024 that may be closed by this pull request
@cmbant cmbant linked an issue Aug 7, 2024 that may be closed by this pull request
cmbant and others added 5 commits August 7, 2024 15:29
misc updates for numpy 2, lint etc
* faster chi2

* misc updates for numpy 2, lint etc

* minor

* linewraps
@ggalloni
Copy link
Collaborator

If modes-specific likelihoods are merged into simonsobs/LAT_MFLike#86, this will need some adjustments. I can take care of that.

@cmbant
Copy link
Collaborator Author

cmbant commented Sep 4, 2024

MFlike changes now merged to master

@cmbant
Copy link
Collaborator Author

cmbant commented Sep 26, 2024

@itrharrison I think OK for public use now mflike changes on pypi

Copy link
Collaborator

@itrharrison itrharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itrharrison itrharrison merged commit 214da74 into master Sep 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFLike Making the mflike versioning more clear
3 participants