Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win test #178

Merged
merged 19 commits into from
Jul 31, 2024
Merged

win test #178

merged 19 commits into from
Jul 31, 2024

Conversation

cmbant
Copy link
Collaborator

@cmbant cmbant commented Jul 10, 2024

No description provided.

@cmbant
Copy link
Collaborator Author

cmbant commented Jul 10, 2024

@itrharrison This seems to be failing because of some bug in tox. I think it is fixed in latest tox, but tox-conda is much older. I don't know how to fix having tried three suggestions. Claude suggests a custom tox plugin, but seems over-engineered. Do we need to use conda for pyccl?

@itrharrison
Copy link
Collaborator

(modulo this issue) Using conda was the easiest cross-platform way of installing all our requirements. pyccl is on pip but its requirements (in particular I think compilers, cmake fftw and gsl) aren't necessarily.

Do you have a link to the bug fix in tox? Could try and contribute its fix to tox-conda.

We could try having a working installation using other package management options. Do you know what you would use in the case of windows?

@cmbant
Copy link
Collaborator Author

cmbant commented Jul 10, 2024

See https://github.com/tox-dev/tox/pull/2391 and linked PRs.. We don't use pyccl on windows, so that shouldn't be an issue. pip should work for camb and most things I think. (camb now has binary wheels, so does not need gfortran to install)

@cmbant
Copy link
Collaborator Author

cmbant commented Jul 26, 2024

I guess the issue is tox-conda currently uses tox<4, so is based on quite old version. (this version pin probably likely to lead to other package version conflicts in future)

itrharrison and others added 7 commits July 26, 2024 14:02
* add version import

* import on runtime and add test of import

* add write_to

* Fix package name

* Flake fixes

* setuptools_scm defaults?

* remove unnecssary extra arg

---------

Co-authored-by: Giacomo Galloni <[email protected]>
* added mflike example

* update install instructions

* docs formatting
@cmbant
Copy link
Collaborator Author

cmbant commented Jul 26, 2024

The problem may have been to do with tox error reporting. With these extra changes to make only relevant tests run (and a fix or two), this now works OK.

@cmbant cmbant requested a review from itrharrison July 26, 2024 13:41
@cmbant cmbant marked this pull request as ready for review July 26, 2024 13:49
@cmbant cmbant linked an issue Jul 26, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@itrharrison itrharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for getting this done

@itrharrison itrharrison merged commit a53b922 into master Jul 31, 2024
6 checks passed
@itrharrison itrharrison deleted the win-test branch July 31, 2024 10:39
itrharrison added a commit that referenced this pull request Aug 1, 2024
* add setuptools_scm to tox requires

* try specify pip ver

* pip ver in workflow

* setuptools and wheel installed in workflow

* try remove pip require

* pin setuptools in workflow

* pin setuptools in workflow lower

* strip out tox-conda

* point to env yaml

* allowlist pytest

* check conda

* allowlist conda

* allowlist in correct section

* correct tox formatting

* activate env in tox

* pytest cov in reqs

* remove vestigial tox-conda comments

* fix docstrings

* update envlist

---------

Co-authored-by: Antony Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows Compatability
2 participants