-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win test #178
win test #178
Conversation
@itrharrison This seems to be failing because of some bug in tox. I think it is fixed in latest tox, but tox-conda is much older. I don't know how to fix having tried three suggestions. Claude suggests a custom tox plugin, but seems over-engineered. Do we need to use conda for pyccl? |
(modulo this issue) Using conda was the easiest cross-platform way of installing all our requirements. pyccl is on pip but its requirements (in particular I think compilers, cmake fftw and gsl) aren't necessarily. Do you have a link to the bug fix in tox? Could try and contribute its fix to tox-conda. We could try having a working installation using other package management options. Do you know what you would use in the case of windows? |
See https://github.com/tox-dev/tox/pull/2391 and linked PRs.. We don't use pyccl on windows, so that shouldn't be an issue. pip should work for camb and most things I think. (camb now has binary wheels, so does not need gfortran to install) |
I guess the issue is tox-conda currently uses tox<4, so is based on quite old version. (this version pin probably likely to lead to other package version conflicts in future) |
* add version import * import on runtime and add test of import * add write_to * Fix package name * Flake fixes * setuptools_scm defaults? * remove unnecssary extra arg --------- Co-authored-by: Giacomo Galloni <[email protected]>
* added mflike example * update install instructions * docs formatting
The problem may have been to do with tox error reporting. With these extra changes to make only relevant tests run (and a fix or two), this now works OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for getting this done
* add setuptools_scm to tox requires * try specify pip ver * pip ver in workflow * setuptools and wheel installed in workflow * try remove pip require * pin setuptools in workflow * pin setuptools in workflow lower * strip out tox-conda * point to env yaml * allowlist pytest * check conda * allowlist conda * allowlist in correct section * correct tox formatting * activate env in tox * pytest cov in reqs * remove vestigial tox-conda comments * fix docstrings * update envlist --------- Co-authored-by: Antony Lewis <[email protected]>
No description provided.