Guess dkim domain automatically #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion, but in 99 % of cases, the DKIM domain could be guessed by the value of
app.urland wouldn't need to be set manually. Even if many users would need to override this, having a sensible default wouldn't hurt. I also addedDKIM_ENABLEDto have a more explicit way of enabling and disabling the DKIM signing.dkim.enabledshould probably befalseby default, but implementing it this way ensures backwards compatibility. If you prefer a clean, breaking change, that could be adapted very easily.