Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib](deps): Bump gym[atari] from 0.18.3 to 0.21.0 in /python/requirements/rllib #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RLlib](deps): Bump gym[atari] from 0.18.3 to 0.21.0 in /python/requirements/rllib #5

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 13, 2021 •
edited
Loading

Bumps gym[atari] from 0.18.3 to 0.21.0.

Release notes

Sourced from gym[atari]'s releases.

0.21.0

-The old Atari entry point that was broken with the last release and the upgrade to ALE-Py is fixed (@​JesseFarebro) -Atari environments now give much clearer error messages and warnings (@​JesseFarebro) -A new plugin system to enable an easier inclusion of third party environments has been added (@​JesseFarebro) -Atari environments now use the new plugin system to prevent clobbered names and other issues (@​JesseFarebro) -pip install gym[atari] no longer distributes Atari ROMs that the ALE (the Atari emulator used) needs to run the various games. The easiest way to install ROMs into the ALE has been to use AutoROM. Gym now has a hook to AutoROM for easier CI automation so that using pip install gym[accept-rom-license] calls AutoROM to add ROMs to the ALE. You can install the entire suite with the shorthand gym[atari, accept-rom-license]. Note that as described in the name name, by installing gym[accept-rom-license] you are confirming that you have the relevant license to install the ROMs. (@​JesseFarebro) -An accidental breaking change when loading saved policies trained on old versions of Gym with environments using the Box2d action space have been fixed. (@​RedTachyon) -Pendulum has had a minor fix to it's physics logic made and the version has been bumped to v1 (@​RedTachyon) -Tests have been refactored into an orderly manner (@​RedTachyon) -Dict spaces now have standard dict helper methods (@​Rohan138) -Environment properties are now forwarded to the wrapper (@​tristandeleu) -Gym now properly enforces calling reset before stepping for the first time (@​ahmedo42) -Proper piping of error messages to stderr (@​XuehaiPan) -Fix video saving issues (@​zlig)

Also, Gym is compiling a list of third party environments to into the new documentation website we're working on. Please submit PRs for ones that are missing: https://github.com/openai/gym/blob/master/docs/third_party_environments.md

0.20.0

Major Change:

  • Replaced Atari-Py dependency with ALE-Py and bumped all versions. This is a massive upgrade with many changes, please see the full explainer (@​JesseFarebro)
  • Note that ALE-Py does not include ROMs. You can install ROMs in two lines of bash with AutoROM though (pip3 install autorom and then autorom), see https://github.com/PettingZoo-Team/AutoROM. This is the recommended approach for CI, etc.

Breaking changes and new features:

  • Add RecordVideo wrapper, deprecate monitor wrapper in favor of it and RecordEpisodeStatistics wrapper (@​vwxyzjn)
  • Dependencies used outside of environments (e.g. for wrappers) are now in 'other' extra' (@​jkterry1)
  • Moved algorithmic and unused toytext envs (guessing game, hotter colder, nchain, roulette, kellycoinflip) to third party repos (@​jkterry1, @​Rohan138)
  • Fixed flatten utility and flatdim in MultiDiscrete sapce (@​tristandeleu)
  • Add __setitem__ to dict space (@​jfpettit)
  • Large fixes to .contains method for box space (@​FirefoxMetzger)
  • Made blackjack environment properly comply with Barto and Sutton book standard, bumped to v1 (@​RedTachyon)
  • Added NormalizeObservation and NormalizeReward wrappers (@​vwxyzjn)
  • Add __getitem__ and __len__ to MultiDiscrete space (@​XuehaiPan)
  • Changed .shape to be a property of box space to prevent unexpected behaviors (@​RedTachyon)

Bug fixes and upgrades:

  • Video recorder gracefully handles closing (@​XuehaiPan)
  • Remaining unnecessary dependencies in setup.py are resolved (@​jkterry1)
  • Minor acrobot performance improvements (@​TuckerBMorgan)
  • Pendulum properly renders when 0 force is sent (@​Olimoyo)
  • Make observations dtypes be consistent with observation space dtypes for all classic control envs and bipedalwalker (@​RedTachyon)
  • Removed unused and long depricated features in registration (@​Rohan138)
  • Framestack wrapper now inherits from obswrapper (@​jfpettit)
  • Seed method for spaces.Tuple and spaces.Dict now properly function, are fully stochastic, are fully featured and behave in the expected manner (@​XuehaiPan, @​RaghuSpaceRajan)
  • Replace time() with perf_counter() for better measurements of short duration (@​zuoxingdong)

0.19.0

Gym 0.19.0 is a large maintenance release, and the first since @​jkterry1 became the maintainer. There should be no breaking changes in this release.

New features:

  • Added custom datatype argument to multidiscrete space (@​m-orsini)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
[RLlib](deps): Bump gym[atari] in /python/requirements/rllib
6b749b5 
Bumps [gym[atari]](https://github.com/openai/gym) from 0.18.3 to 0.21.0.
- [Release notes](https://github.com/openai/gym/releases)
- [Commits](openai/gym@0.18.3...v0.21.0)

---
updated-dependencies:
- dependency-name: gym[atari]
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 13, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 5, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

3 similar comments
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 27, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 27, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 8, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 12, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

12 similar comments
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 25, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 31, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 13, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 20, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Apr 26, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github May 13, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github May 14, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github May 21, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github May 27, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github May 27, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jun 2, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jun 6, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

simonsays1980 pushed a commit that referenced this pull request Aug 21, 2022
@kfstorm
[Core] No RAY_LOG in the constructor of DelayManager (ray-project#26958)
34d0233 
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
simonsays1980 pushed a commit that referenced this pull request Mar 10, 2023
@jianoaix
[Datasets] Streaming executor fixes #5 (ray-project#32951)
303ac3b
sven1977 added a commit that referenced this pull request Jan 19, 2024
@sven1977
[RLlib] New ConnectorV3 API #5: PPO runs in single-agent mode in this…
e03dd6e 
… API stack. (ray-project#42272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants