Prepare for upcoming breaking changes in FastBoot 1.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, here is some context: ember-fastboot/ember-cli-fastboot#360 Not sure what's happening with Travis again, cannot install phantomjs? |
kratiahuja
reviewed
Apr 14, 2017
| @@ -46,8 +43,9 @@ module.exports = { | |||
| }, | |||
|
|
|||
| config(env, baseConfig) { | |||
| if (!env) | |||
| if (!env) { | |||
There was a problem hiding this comment.
When is env not going to be defined?
There was a problem hiding this comment.
I can't really remember, why I introduce this guard. Maybe to eliminate any possibility of being the cause of a bug in early days. I will remove this in the next release.
|
The failing tests are due to yarnpkg/yarn#3138 😞 |
|
@simonihmig should we force travis to use a later node version? |
|
Yes, we could so, as a workaround, but should revert once the yarn bug is fixed! |
This was referenced Apr 21, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things will be gone with the upcoming FastBoot 1.0 release:
process.env.EMBER_CLI_FASTBOOT(as there is just one unified build step)initializer/(browser|fastboot)/*(again, just one build)The changes here should continue to work with pre 1.0 and also support post 1.0 versions.