-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Upload newer #100
base: master
Are you sure you want to change the base?
[wip] Upload newer #100
Conversation
Hi @simonh1000, I see you have added the check based on the size and date attribute. Could the system maybe create a file with all the uploaded files with the hash of the file.
Then the only thing that needs to be done is get the file and check the hashes locally or in CI/CD process and upload only different files. Maybe size would benefit because of speed, so only check the hash if the size is different. This will also make a rollback easier |
I certainly share your use case - I end up re-uploading a bunch of assets that are copied over with each build as that's also creating a new copy. In my case, maybe some tweaking of webpack to make it more sophisticated might be enough, but I can see that that will not help if you have to use the output of CI. I'm not sure how I feel about leaving a file on someone's server though. Need to think about that and would welcome others' views |
Hi @simonh1000, I was wondering if there is any progress since in this PR and its conflicts as I would be interested in using this new feature :-) |
Hi @erwineverts and @drikusroor - if still interested maybe checkout PR #117 - it will use a generated hash-sum file. |
closes #42