feat: Use templates from Firebase SDK's directly in the init generator #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondotm
deleted the
213-use-firebase-sdk-template-in-the-init-generator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin init generator is now using templates direct from the Firebase SDK.
They are copied from the SDK as a
postinstallscript, and match the SDK version shipped with the plugin releases.Note that the generated
main.tsfor functions now no longer contains:since this is not in the Firebase SDK functions template.
Also, when the firebase app generator runs it will set a 30-day expiry in
firestore.rulesthe same way the firebase CLI does.