Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emulator target setTimeout not working #108

Merged
merged 1 commit into from
May 7, 2023

Conversation

rosslavery
Copy link
Contributor

On Windows (and possibly other platforms), the setTimeout before calling kill-port is not working as expected.

Problem

  • The delay is not adhered to, and the kill-port runs immediately
  • An empty file with the name {} is written to disk in the root of the workspace

image

Solution

  • Modify and escape the code passed to node -e to fix the above-mentioned problems

@simondotm
Copy link
Owner

Thanks for the fix @rosslavery

@simondotm simondotm merged commit bfeeeea into simondotm:main May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants