-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move native code, gypfile to subdir to fix #23.
electron-rebuild will blindly run any top-level binding.gyp, which will fail due to the missing dep, but also is a waste of time as this is N-API and Windows only, so there's no reason to ever rebuild it. Save such users by moving the binding.gyp the only way that works AFAIK, by providing a --cwd to prebuildify.
- Loading branch information
1 parent
eb1b4d0
commit dc65547
Showing
7 changed files
with
13 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
.*/ | ||
!/.idea/ | ||
/.idea/workspace.xml | ||
/build/ | ||
/binding/build/ | ||
/binding/prebuilds/ | ||
/lib/ | ||
/prebuilds/ | ||
node_modules/ | ||
yarn-error.log* | ||
*.tgz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/.idea/ | ||
/.vs/ | ||
/build/ | ||
/binding/build/ | ||
/examples/ | ||
*.log |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,8 @@ | |
"lib", | ||
"src", | ||
"test", | ||
"prebuilds", | ||
"binding.gyp", | ||
"binding/prebuilds", | ||
"binding/binding.gyp", | ||
"*.cc" | ||
], | ||
"scripts": { | ||
|
@@ -29,8 +29,8 @@ | |
"clean": "rimraf build lib prebuilds", | ||
"build": "yarn build:js && yarn build:ia32 && yarn build:x64", | ||
"build:js": "tsc -p src", | ||
"build:ia32": "prebuildify --napi --target [email protected] --arch ia32", | ||
"build:x64": "prebuildify --napi --target [email protected] --arch x64", | ||
"build:ia32": "prebuildify --napi --target [email protected] --cwd binding --arch ia32", | ||
"build:x64": "prebuildify --napi --target [email protected] --cwd binding --arch x64", | ||
"test": "mocha --ui tdd" | ||
}, | ||
"dependencies": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters