Fix regression of #23, pin node version with volta.

simonbuchan · Nov 29, 2022 · d5a4108 · d5a4108
1 parent 342b58f
commit d5a4108
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v1.1.1] - 2022-11-30
+
+### Fixed
+
+- [#35](https://github.com/simonbuchan/native-reg/issues/35) which is a regression in 1.1.0 of
+  [#23](https://github.com/simonbuchan/native-reg/issues/23) fixed in 0.3.6.
+  Should only affect non-windows builds using `electron-rebuild`.
+
 ## [v1.1.0] - 2022-08-01
 
 ### Added

diff --git a/binding.gyp b/binding.gyp
@@ -8,7 +8,14 @@
       "include_dirs": [
         "<!@(node -p \"require('node-addon-api').include\")",
       ],
-      "sources": [ "reg.cc" ],
+      "conditions": [
+        [
+          "OS==\"win\"",
+          {
+            "sources": ["reg.cc"]
+          }
+        ]
+      ],
       "msvs_settings": {
         "VCCLCompilerTool": {
           "AdditionalOptions": [

diff --git a/package.json b/package.json
@@ -11,6 +11,10 @@
     "registry",
     "native"
   ],
+  "volta": {
+    "node": "16.18.1",
+    "yarn": "1.22.19"
+  },
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "files": [