Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare to
DEFAULT_CIPHERS
I removedECDH+AESGCM
andDH+AESGCM
, they don't seem to be required. My tests show that all other ciphers are required.We've got many people who are unable to authorize and get master token: leikoilja/ha-google-home#95
It turns out that other libraries may alter
DEFAULT_CIPHERS
: example. This has already been fixed but I thinkgpsoauth
shouldn't depend onDEFAULT_CIPHERS
which may also change in the new releases ofurllib3
.This will make
gpsoauth
more robust.