This repository has been archived by the owner on Feb 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 274
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor builder and browser out of the project.
- Loading branch information
Showing
75 changed files
with
942 additions
and
3,123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,77 @@ | ||
| # OS-specific files | ||
| # Miscellaneous | ||
| *.class | ||
| *.lock | ||
| *.log | ||
| *.pyc | ||
| *.swp | ||
| .DS_Store | ||
| .atom/ | ||
| .buildlog/ | ||
| .history | ||
| .svn/ | ||
|
|
||
| # Files and directories created by pub | ||
| .packages | ||
| .pub/ | ||
| build/ | ||
| # Remove the following pattern if you wish to check in your lock file | ||
| pubspec.lock | ||
|
|
||
| .dart_tool/ | ||
|
|
||
| # Directory created by dartdoc | ||
| doc/api/ | ||
|
|
||
| # Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and Webstorm | ||
| # Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839 | ||
|
|
||
| # User-specific stuff: | ||
| .idea/ | ||
|
|
||
| ## File-based project format: | ||
| # IntelliJ related | ||
| *.iml | ||
| *.ipr | ||
| *.iws | ||
| .idea/ | ||
|
|
||
| ## Plugin-specific files: | ||
|
|
||
| # IntelliJ | ||
| out/ | ||
| **.iml | ||
| # The .vscode folder contains launch configuration and tasks you configure in | ||
| # VS Code which you may wish to be included in version control, so this line | ||
| # is commented out by default. | ||
| #.vscode/ | ||
|
|
||
| .vscode/** | ||
| # Flutter/Dart/Pub related | ||
| **/doc/api/ | ||
| .dart_tool/ | ||
| .flutter-plugins | ||
| .flutter-plugins-dependencies | ||
| .packages | ||
| .pub-cache/ | ||
| .pub/ | ||
| build/ | ||
|
|
||
| # mpeltonen/sbt-idea plugin | ||
| .idea_modules/ | ||
| # Android related | ||
| **/android/**/gradle-wrapper.jar | ||
| **/android/.gradle | ||
| **/android/captures/ | ||
| **/android/gradlew | ||
| **/android/gradlew.bat | ||
| **/android/local.properties | ||
| **/android/**/GeneratedPluginRegistrant.java | ||
|
|
||
| .idea/markdown-navigator.xml | ||
| .idea/* | ||
| # iOS/XCode related | ||
| **/ios/**/*.mode1v3 | ||
| **/ios/**/*.mode2v3 | ||
| **/ios/**/*.moved-aside | ||
| **/ios/**/*.pbxuser | ||
| **/ios/**/*.perspectivev3 | ||
| **/ios/**/*sync/ | ||
| **/ios/**/.sconsign.dblite | ||
| **/ios/**/.tags* | ||
| **/ios/**/.vagrant/ | ||
| **/ios/**/DerivedData/ | ||
| **/ios/**/Icon? | ||
| **/ios/**/Pods/ | ||
| **/ios/**/.symlinks/ | ||
| **/ios/**/profile | ||
| **/ios/**/xcuserdata | ||
| **/ios/.generated/ | ||
| **/ios/Flutter/App.framework | ||
| **/ios/Flutter/Flutter.framework | ||
| **/ios/Flutter/Flutter.podspec | ||
| **/ios/Flutter/Generated.xcconfig | ||
| **/ios/Flutter/app.flx | ||
| **/ios/Flutter/app.zip | ||
| **/ios/Flutter/flutter_assets/ | ||
| **/ios/Flutter/flutter_export_environment.sh | ||
| **/ios/ServiceDefinitions.json | ||
| **/ios/Runner/GeneratedPluginRegistrant.* | ||
|
|
||
| # Generated test coverage | ||
| coverage.json | ||
| lcov.info | ||
| test_coverage | ||
| # Exceptions to above rules. | ||
| !**/ios/**/default.mode1v3 | ||
| !**/ios/**/default.mode2v3 | ||
| !**/ios/**/default.pbxuser | ||
| !**/ios/**/default.perspectivev3 | ||
| !/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages | ||
| /example/*.lock |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,172 +1,70 @@ | ||
| include: package:lints/recommended.yaml | ||
| analyzer: | ||
| exclude: | ||
| - "**/*.g.dart" | ||
| language: | ||
| strict-raw-types: false | ||
| strong-mode: | ||
| implicit-casts: false | ||
| implicit-casts: true | ||
| implicit-dynamic: false | ||
| errors: | ||
| always_declare_return_types: error | ||
| always_specify_types: error | ||
| annotate_overrides: error | ||
| argument_type_not_assignable: error | ||
| avoid_function_literals_in_foreach_calls: error | ||
| avoid_renaming_method_parameters: error | ||
| avoid_types_on_closure_parameters: error | ||
| avoid_unnecessary_containers: error | ||
| await_only_futures: error | ||
| body_might_complete_normally_nullable: error | ||
| camel_case_types: error | ||
| curly_braces_in_flow_control_structures: error | ||
| dead_code: error | ||
| duplicate_import: error | ||
| file_names: error | ||
| implicit_dynamic_function: ignore | ||
| implicit_dynamic_parameter: error | ||
| implicit_dynamic_list_literal: ignore | ||
| implicit_dynamic_map_literal: ignore | ||
| implicit_dynamic_method: ignore | ||
| implicit_dynamic_type: ignore | ||
| implicit_dynamic_variable: ignore | ||
| invalid_assignment: error | ||
| missing_return: error | ||
| must_be_immutable: error | ||
| prefer_adjacent_string_concatenation: error | ||
| prefer_const_constructors: error | ||
| prefer_const_constructors_in_immutables: error | ||
| prefer_const_declarations: error | ||
| prefer_collection_literals: error | ||
| prefer_contains: error | ||
| prefer_const_literals_to_create_immutables: error | ||
| prefer_interpolation_to_compose_strings: error | ||
| prefer_is_empty: error | ||
| prefer_final_fields: error | ||
| prefer_single_quotes: error | ||
| require_trailing_commas: error | ||
| sized_box_for_whitespace: error | ||
| sort_constructors_first: error | ||
| sort_unnamed_constructors_first: error | ||
| todo: ignore | ||
| use_function_type_syntax_for_parameters: error | ||
| use_key_in_widget_constructors: error | ||
| unnecessary_import: error | ||
| unnecessary_type_check: error | ||
| unnecessary_string_interpolations: error | ||
| unnecessary_this: error | ||
| unused_element: error | ||
| unused_import: error | ||
| unused_local_variable: error | ||
| dead_code: error | ||
| public_member_api_docs: ignore # turned on by user-facing subpackages | ||
| exclude: | ||
| - "**/*.g.dart" | ||
| # Will be analyzed anyway, nobody knows why ¯\_(ツ)_/¯. We're only analyzing lib/ and test/ as a workaround | ||
| - ".dart_tool/build/entrypoint/build.dart" | ||
|
|
||
| # this should always include all rules. Those we don't use are commented out | ||
| use_rethrow_when_possible: error | ||
| linter: | ||
| rules: | ||
| # ERROR RULES | ||
| - avoid_empty_else | ||
| # - avoid_print (all our prints can be disabled) | ||
| - avoid_relative_lib_imports | ||
| - avoid_returning_null_for_future | ||
| # - avoid_slow_async_io | ||
| - avoid_types_as_parameter_names | ||
| - cancel_subscriptions | ||
| - close_sinks | ||
| - comment_references | ||
| - control_flow_in_finally | ||
| # - diagnostic_describe_all_properties (Flutter-specific, not relevant for us) | ||
| - empty_statements | ||
| - hash_and_equals | ||
| # - invariant_booleans (turned off because the lint rule is buggy) | ||
| - iterable_contains_unrelated_type | ||
| - list_remove_unrelated_type | ||
| - literal_only_boolean_expressions | ||
| - no_adjacent_strings_in_list | ||
| - no_duplicate_case_values | ||
| # - prefer_relative_imports (clashes with avoid_relative_lib_imports) | ||
| # - prefer_void_to_null (we do use Null as a type for alwaysThrows functions) | ||
| - test_types_in_equals | ||
| - throw_in_finally | ||
| - unnecessary_statements | ||
| - unrelated_type_equality_checks | ||
| - unsafe_html | ||
| - valid_regexps | ||
| # STYLE RULES | ||
| - always_declare_return_types | ||
| # - always_put_control_body_on_new_line (we don't do this if it fits on the same line) | ||
| # - always_put_required_named_parameters_first (we just don't do this) | ||
| # - always_require_non_null_named_parameters (we don't use assert foo != null for parameters) | ||
| # - always_specify_types (we prefer to omit the type parameter when possible) | ||
| - annotate_overrides | ||
| # - avoid_annotating_with_dynamic (we prefer to make dynamic explicit) | ||
| # - avoid_as (we prefer to make explicit casts explicit!) | ||
| - avoid_bool_literals_in_conditional_expressions | ||
| - avoid_catches_without_on_clauses | ||
| - avoid_catching_errors | ||
| - avoid_classes_with_only_static_members | ||
| - avoid_double_and_int_checks | ||
| # - avoid_equals_and_hash_code_on_mutable_classes (lint is to generic for transient fields) | ||
| - avoid_field_initializers_in_const_classes | ||
| - avoid_function_literals_in_foreach_calls | ||
| # - avoid_implementing_value_types (maybe we can consider turning this on?) | ||
| - avoid_init_to_null | ||
| - avoid_js_rounded_ints | ||
| - avoid_null_checks_in_equality_operators | ||
| # - avoid_positional_boolean_parameters (there pretty useful when there's only one boolean param) | ||
| # - avoid_private_typedef_functions (they're still useful) | ||
| - avoid_renaming_method_parameters | ||
| - avoid_return_types_on_setters | ||
| - avoid_returning_null | ||
| - avoid_returning_null_for_void | ||
| - avoid_returning_this | ||
| - avoid_setters_without_getters | ||
| - avoid_shadowing_type_parameters | ||
| - avoid_single_cascade_in_expression_statements | ||
| # - avoid_types_on_closure_parameters (the interference isn't THAT good) | ||
| # - avoid_unnecessary_containers (Flutter-specific, not relevant here) | ||
| - avoid_unused_constructor_parameters | ||
| - avoid_void_async | ||
| - await_only_futures | ||
| - camel_case_extensions | ||
| - camel_case_types | ||
| # - cascade_invocations (sometimes the explicit notation is more readable) | ||
| - constant_identifier_names | ||
| - curly_braces_in_flow_control_structures | ||
| - directives_ordering | ||
| - empty_catches | ||
| - empty_constructor_bodies | ||
| - file_names | ||
| # - flutter_style_todos (Flutter-development specific, not relevant here) | ||
| - implementation_imports | ||
| - join_return_with_assignment | ||
| - library_names | ||
| - library_prefixes | ||
| #- lines_longer_than_80_chars ignored because it's annoying for long literals in tests | ||
| - non_constant_identifier_names | ||
| - null_closures | ||
| - omit_local_variable_types | ||
| - one_member_abstracts | ||
| - only_throw_errors | ||
| - overridden_fields | ||
| - package_api_docs | ||
| # - package_prefixed_library_names (this isn't java) | ||
| # - parameter_assignments (we regularly use this to set default values) | ||
| - prefer_adjacent_string_concatenation | ||
| - prefer_asserts_in_initializer_lists | ||
| # - prefer_asserts_with_message (it's annoying to write messages for internal invariants) | ||
| - prefer_collection_literals | ||
| - prefer_conditional_assignment | ||
| - prefer_const_constructors | ||
| - prefer_const_constructors_in_immutables | ||
| - prefer_const_declarations | ||
| - prefer_const_literals_to_create_immutables | ||
| - prefer_constructors_over_static_methods | ||
| - prefer_contains | ||
| # - prefer_double_quotes (we prefer single quotes) | ||
| - prefer_equal_for_default_values | ||
| # - prefer_expression_function_bodies (for multiline expressions, this is ugly to format) | ||
| - prefer_final_fields | ||
| - prefer_final_in_for_each | ||
| - prefer_final_locals | ||
| - prefer_for_elements_to_map_fromIterable | ||
| - prefer_foreach | ||
| - prefer_function_declarations_over_variables | ||
| - prefer_generic_function_type_aliases | ||
| - prefer_if_elements_to_conditional_expressions | ||
| - prefer_if_null_operators | ||
| - prefer_initializing_formals | ||
| - prefer_inlined_adds | ||
| - prefer_int_literals | ||
| - prefer_interpolation_to_compose_strings | ||
| - prefer_is_empty | ||
| - prefer_is_not_empty | ||
| - prefer_is_not_operator | ||
| - prefer_iterable_whereType | ||
| # - prefer_mixin (todo we could consider enabling this) | ||
| - prefer_null_aware_operators | ||
| - prefer_single_quotes | ||
| - prefer_spread_collections | ||
| - prefer_typing_uninitialized_variables | ||
| - provide_deprecation_message | ||
| - public_member_api_docs | ||
| - recursive_getters | ||
| - slash_for_doc_comments | ||
| # - sort_child_properties_last (Flutter specific) | ||
| # - sort_constructors_first (we don't do this) | ||
| # - sort_unnamed_constructors_first | ||
| #- type_annotate_public_apis (very annoying because it flags tests) | ||
| - type_init_formals | ||
| - unawaited_futures | ||
| - unnecessary_brace_in_string_interps | ||
| - unnecessary_const | ||
| # - unnecessary_final (we prefer final here) | ||
| - unnecessary_getters_setters | ||
| - unnecessary_lambdas | ||
| - unnecessary_new | ||
| - unnecessary_null_aware_assignments | ||
| - unnecessary_null_in_if_null_operators | ||
| - unnecessary_overrides | ||
| - unnecessary_parenthesis | ||
| - unnecessary_this | ||
| # - use_full_hex_values_for_flutter_colors (Flutter specific) | ||
| - use_function_type_syntax_for_parameters | ||
| - use_rethrow_when_possible | ||
| - use_setters_to_change_properties | ||
| - use_string_buffers | ||
| # - use_to_and_as_if_applicable (false positive on operators) | ||
| - void_checks | ||
| # PUB RULES | ||
| - package_names | ||
| # - sort_pub_dependencies (we prefer to group them by what they do) | ||
| avoid_print: false | ||
| prefer_interpolation_to_compose_strings: true | ||
| prefer_single_quotes: true | ||
| require_trailing_commas: true | ||
| # always_use_package_imports: true | ||
| sort_constructors_first: true | ||
| sort_unnamed_constructors_first: true |
Oops, something went wrong.