Skip to content

Commit

Permalink
linter check
Browse files Browse the repository at this point in the history
  • Loading branch information
OzBena committed Aug 15, 2024
1 parent 5b4108e commit cde6866
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/super-linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
packages: read
# To report GitHub Actions status checks
statuses: write

steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -30,4 +30,4 @@ jobs:
env:
VALIDATE_ALL_CODEBASE: false
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VALIDATE_GO_MODULES: true
VALIDATE_GO: true
12 changes: 9 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,24 +47,30 @@ To contribute code:

1. **Fork the Repository**: Create a personal fork of the repository on GitHub.
2. **Clone Your Fork**: Clone your fork to your local machine.
3. **Create a New Branch**: Follow the branch naming convention provided in the [Commit Message Convention](#commit-message-convention) section.
3. **Create a New Branch**: Follow the branch naming convention provided in the [Brach Naming Convention](#branch-naming-convention) section.
4. **Make Your Changes**: Implement your changes in your branch.
5. **Run Linter**: Ensure your code passes `golangci-lint`.
6. **Test Your Changes**: Write tests for your code and ensure all tests pass.
7. **Submit a Pull Request**: Push your branch to GitHub and [open a pull request](https://github.com/similarweb/bbox/compare) against the main branch.

## Commit Message Convention
## Branch Naming Convention

We follow a specific convention for commit messages to maintain consistency and clarity. Please use the following format:

```bash
[type] [scope] Summary
[type]/[scope]_Summary
```

- **Type**: The type of change (e.g., feat, fix, improve, cleanup, refactor, revert).
- **Scope**: The scope of the change (e.g., admin, cli, docker, multi-trigger, test, ci, build, version, doc, auth).
- **Summary**: A brief, self-explanatory description of the change in present tense imperative, starting with a capital letter and no period at the end.

For example:

```bash
feat/clean_add-new-clean-feature
```

## Style Guide

Please adhere to the following coding standards:
Expand Down
2 changes: 1 addition & 1 deletion cmd/clean/vcsRoot.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const (
)

var autoDelete bool

var unusedVar = "unused"
var vcsRootsCmdName = "vcs"

var vcsRootsCmd = &cobra.Command{
Expand Down

0 comments on commit cde6866

Please sign in to comment.