Merge pull request Azure#1093 from jianghaolu/validatorfix

Fix bug in validator that stack overflows on final/static fields
sima-zhu · Sep 21, 2016 · d67ca69 · d67ca69
2 parents 245aba2 + 00b45db
commit d67ca69
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/client-runtime/src/main/java/com/microsoft/rest/Validator.java b/client-runtime/src/main/java/com/microsoft/rest/Validator.java
@@ -16,6 +16,7 @@
 import org.joda.time.Period;
 
 import java.lang.reflect.Field;
+import java.lang.reflect.Modifier;
 import java.util.List;
 import java.util.Map;
 
@@ -63,6 +64,11 @@ public static void validate(Object parameter) throws IllegalArgumentException {
             }
             for (Field field : c.getDeclaredFields()) {
                 field.setAccessible(true);
+                int mod = field.getModifiers();
+                // Skip static fields since we don't have any, skip final fields since users can't modify them
+                if (Modifier.isFinal(mod) || Modifier.isStatic(mod)) {
+                    return;
+                }
                 JsonProperty annotation = field.getAnnotation(JsonProperty.class);
                 Object property;
                 try {