Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.app.view.CustomPlotSelectionWindow : Add dataset directly from silx + drop overlay on plot #4141

Merged
merged 9 commits into from
Jun 27, 2024

Conversation

RebeloAlexis
Copy link
Contributor

@RebeloAlexis RebeloAlexis commented Jun 24, 2024

Added functionality to enhance the user experience.

1. Added functionality for adding X or Y datasets directly from the main page

To do this, simply :

  • Open silx view
  • Select a file
  • Right-click on the dataset and choose one of the 2 options (see image)
    - Set abscissa to plot selection
    - Add ordinate to plot selection
  • The "Plot Selection" page will open

image

2. Add user feedback when dropping on the plot

image

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I left a few minor comments

src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/CustomPlotSelectionWindow.py Outdated Show resolved Hide resolved
src/silx/app/view/CustomPlotSelectionWindow.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
src/silx/app/view/Viewer.py Outdated Show resolved Hide resolved
@t20100
Copy link
Member

t20100 commented Jun 27, 2024

Great improvement! I'll merge once CI as run

@t20100 t20100 merged commit 1ff038d into silx-kit:main Jun 27, 2024
7 of 8 checks passed
@RebeloAlexis RebeloAlexis deleted the userExperience branch June 28, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants