Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get data without schema #3859

Merged
merged 3 commits into from
Jun 15, 2023
Merged

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Jun 14, 2023

This PR move back a feature from CompareImagesWindow to the core silx.io.utils.get_data.

Closes #3852

Changelog:

  • Added support of bare file from silx.io.utils.get_data with check_schemas=True

@vallsv vallsv requested a review from t20100 June 14, 2023 16:01
@vallsv vallsv self-assigned this Jun 14, 2023
@vallsv vallsv added this to the 2.0.0 milestone Jun 14, 2023
@t20100
Copy link
Member

t20100 commented Jun 15, 2023

CI fails:

silx/io/utils.py:857: in <module>
    def get_data(url: Union[str,silx.io.url.DataUrl], check_schemas: bool=False):
E   AttributeError: module 'silx' has no attribute 'io'

depistes import silx.io.url...

🤷

src/silx/io/utils.py Outdated Show resolved Hide resolved
src/silx/io/utils.py Outdated Show resolved Hide resolved
@t20100
Copy link
Member

t20100 commented Jun 15, 2023

This will make get_data simpler to use!

@vallsv vallsv force-pushed the get-data-without-schema branch from 72b06e0 to a28bee0 Compare June 15, 2023 08:36
@vallsv
Copy link
Contributor Author

vallsv commented Jun 15, 2023

Here is an update

@vallsv vallsv force-pushed the get-data-without-schema branch from a28bee0 to a520fea Compare June 15, 2023 09:09
@vallsv
Copy link
Contributor Author

vallsv commented Jun 15, 2023

CI fails:

silx/io/utils.py:857: in <module>
    def get_data(url: Union[str,silx.io.url.DataUrl], check_schemas: bool=False):
E   AttributeError: module 'silx' has no attribute 'io'

depistes import silx.io.url...

shrug

I think it's because utils is imported by silx.io.__init__, so it was maybe creating weird behaviour depending on the way you was import this functions.

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/silx/io/utils.py Outdated Show resolved Hide resolved
src/silx/io/utils.py Outdated Show resolved Hide resolved
@vallsv vallsv force-pushed the get-data-without-schema branch from a520fea to a079fe1 Compare June 15, 2023 11:36
@vallsv
Copy link
Contributor Author

vallsv commented Jun 15, 2023

The PR was updated.

@t20100 t20100 merged commit 5347187 into silx-kit:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move compareimagewindow readData into get_data
2 participants