Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompareImages: Fix the A-B visualization mode #3856

Merged
merged 5 commits into from
Jun 15, 2023

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Jun 14, 2023

The previous implementation was trying to constraint the data on the same data range, anyway the visualization mode.

This approach is fine for most of the modes, except A-B.

  • Now A-B is handled in a special way, in order to use the basic operation A-B
  • The colormap is now updated (when we switch between the visualization mode) in order to stay in the same data range
  • Plus an RGB improvement to use any colormap normaization (before it was only a linear scale)

No changelog is needed as it's just a kind of partial revert of the previous change

Changelog:

@vallsv vallsv requested a review from t20100 June 14, 2023 15:07
@vallsv vallsv self-assigned this Jun 14, 2023
@vallsv vallsv added this to the 2.0.0 milestone Jun 14, 2023
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good to have set|getVisualizationMode on the item

@t20100 t20100 merged commit 73df45e into silx-kit:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants