silx.gui.plot.items.roi: Added RegionOfInterest's getText and setText methods
#3847
Conversation
| qt.QObject.__init__(self) | ||
| if parent is not None: | ||
| self.setParent(parent) |
There was a problem hiding this comment.
This was needed with PySide6 6.5.0 on macos with python3.10
| def getText(self) -> str: | ||
| """Returns the currently displayed text for this ROI""" | ||
| return self.getName() if self.__text is None else self.__text | ||
|
|
||
| def setText(self, text: Optional[str] = None) -> None: | ||
| """Set the displayed text for this ROI. | ||
|
|
||
| If None (the default), the ROI name is used. | ||
| """ |
There was a problem hiding this comment.
I choose set|getText rather than set|getLabel since plot markers already have some set|getText methods.
| def _updateText(self, text: str) -> None: | ||
| """Update the text displayed by this ROI | ||
|
|
||
| Override in subclass to custom text display | ||
| """ | ||
| pass |
There was a problem hiding this comment.
This has moved from HandleBasedROI
| @@ -437,6 +441,26 @@ def setVisible(self, visible): | |||
| self._visible = visible | |||
| self._updated(items.ItemChangedType.VISIBLE) | |||
|
|
|||
| def getText(self) -> str: | |||
| """Returns the currently displayed text for this ROI""" | |||
| return self.getName() if self.__text is None else self.__text | |||
There was a problem hiding this comment.
I would prefer to decouple the text property from the name.
You could see the use of the name as a display mode (which we don't have to handle explicitly).
What do you think?
But i dont see any problem with the actual implementation.
There was a problem hiding this comment.
What do you mean? Having getText always returning self.__text (eventually None) and an extra method, e.g., getDisplayedText, to retrieve what should be displayed?
There was a problem hiding this comment.
After discussion, this is fine as it is
|
Very nice. I think this will simplify more things than i was expecting. |
Added 2 methods to change the displayed text of ROIs without changing its name.
The default behavior (
setText(None)) is to display the ROI's name.This PR also contains a fix for PySide6 for RegionOfInterest.
closes #3817