Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OrderedDict by dict #3830

Merged
merged 1 commit into from
May 22, 2023
Merged

Replace OrderedDict by dict #3830

merged 1 commit into from
May 22, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented May 17, 2023 •
edited
Loading

With python>=3.7, there is no longer need to use OrderedDict, so replace it with dict, except when using OrderedDict specific methods: popitem(last=False) (1 occurence) or move_to_end (0 occurence).

@t20100 t20100 added this to the 2.0.0 milestone May 17, 2023
@t20100 t20100 force-pushed the remove-ordereddict branch from 9364bc5 to 5cd0307 Compare May 17, 2023 12:22
@t20100 t20100 marked this pull request as ready for review May 17, 2023 14:17
@payno
Copy link
Member

payno commented May 22, 2023

LGTM. Can it be merged ?

@vallsv
Copy link
Contributor

vallsv commented May 22, 2023

There is no reason not to merge it i think.
If there is remaining stuffs, this can be fixed later.

@vallsv vallsv requested a review from payno May 22, 2023 07:18
@vallsv vallsv merged commit 4406825 into silx-kit:main May 22, 2023
@vallsv vallsv self-requested a review May 22, 2023 08:25
@t20100 t20100 deleted the remove-ordereddict branch May 22, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@payno payno Awaiting requested review from payno

@vallsv vallsv Awaiting requested review from vallsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t20100 @payno @vallsv