-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url with slices #3821
Fix url with slices #3821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed support of slice was missing.
Let's keep helper functions (slice_to_string
and slice_sequence_to_string
) private to make it clear it's not part of the API.
f5a9405
to
15eefca
Compare
Here is with fixes.
|
One corner case: How does it work with |
(basically there is the same bug in UrlSelectionTable, cause it was a copy paste, i prefer to use the same base code for now) |
@t20100 what |
Actually
I suggest to rework that to have
but i am really not sure, it's maybe better to change that in another PR |
From https://numpy.org/doc/stable/user/basics.indexing.html :
Basically it returns everything but it also works with scalars:
|
Acutally it should be OK as it is: |
Ok, nice, i prefer not to touch this semantic. It's just that there is an inconsistency because |
This was just not implemented.
Changelog: