Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #3814

Merged
merged 1 commit into from
May 11, 2023
Merged

Remove unused imports #3814

merged 1 commit into from
May 11, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented May 11, 2023

This PR cleans-up most of the unused imports spotted by pylint.
I left the ones with side effects (matplotlib, Qt bindings) and didn't touch silx.opencl.

@t20100 t20100 added this to the 2.0.0 milestone May 11, 2023
@vallsv vallsv requested review from vallsv May 11, 2023 08:59
@vallsv
Copy link
Contributor

vallsv commented May 11, 2023

👍

Any idea if it is easy to drop this import *?

@t20100
Copy link
Member Author

t20100 commented May 11, 2023

+1

Any idea if it is easy to drop this import *?

Which one?

@t20100 t20100 merged commit 2da7972 into silx-kit:main May 11, 2023
@t20100 t20100 deleted the remove-unused-import branch May 11, 2023 09:17
@vallsv
Copy link
Contributor

vallsv commented May 11, 2023

The ones part of your changes. I think it was inside sift or processing.

@t20100
Copy link
Member Author

t20100 commented May 11, 2023

OK, if it's in the diff of this PR, then it's the src/silx/image/*.py which are wrapper to their counterparts in src/silx/opencl/.

IMO those modules could be deprecated and use directly silx.opencl.*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants