Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve url selection #3797

Merged
merged 8 commits into from
May 10, 2023
Merged

Improve url selection #3797

merged 8 commits into from
May 10, 2023

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented May 4, 2023 •
edited
Loading

Changelog:

  • UrlSelection:
    • Rework the look and feel
    • Allow to drop an URL from silx view
    • Fixes typos on variable names

@vallsv vallsv requested review from t20100 and payno May 4, 2023 16:35
@vallsv vallsv changed the title Improve url selection Draft: Improve url selection May 4, 2023
@vallsv vallsv force-pushed the improve-url-selection branch from 3621e66 to 0addff9 Compare May 5, 2023 08:18
@vallsv vallsv changed the title Draft: Improve url selection Improve url selection May 5, 2023
@vallsv
Copy link
Contributor Author

vallsv commented May 5, 2023

This is ready to review

@t20100 t20100 added this to the 2.0.0 milestone May 5, 2023
payno
payno approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@payno payno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement great.

src/silx/gui/widgets/UrlSelectionTable.py Outdated Show resolved Hide resolved
@vallsv vallsv force-pushed the improve-url-selection branch from 0addff9 to 468de92 Compare May 9, 2023 15:41
@vallsv
Copy link
Contributor Author

vallsv commented May 9, 2023

Here is an update with some tests

@vallsv vallsv force-pushed the improve-url-selection branch from 468de92 to d397f57 Compare May 9, 2023 15:46
@t20100 t20100 merged commit eeb8c44 into silx-kit:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 approved these changes

@payno payno payno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vallsv @t20100 @payno