Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram visibility #3742

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix histogram visibility #3742

merged 1 commit into from
Jan 5, 2023

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Dec 21, 2022

This PR fixes the setSideHistogramDisplayed(False) when the widget or one of the ancestor is not visible.

isVisible() is one of the property which is not symmetric to setVisible().

As result isSideHistogramDisplayed was false is some cases for false reason.
Which was inhibiting setSideHistogramDisplayed.

Changelog:

  • Fix ImageView histogram visibility

@vallsv vallsv added the bug label Dec 21, 2022
@vallsv vallsv requested a review from t20100 December 21, 2022 11:01
@vallsv vallsv self-assigned this Dec 21, 2022
@vallsv
Copy link
Contributor Author

vallsv commented Dec 21, 2022

The following code from ImageStack`looks to have the same problem

    def urlSelectionTableIsVisible(self):
        return self._urlsTable.isVisible()

@t20100 t20100 added this to the Next release milestone Jan 5, 2023
@t20100 t20100 merged commit 36c1708 into master Jan 5, 2023
@t20100 t20100 deleted the fix-histo-visibility branch January 5, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants