Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation #3699

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Updated documentation #3699

merged 4 commits into from
Oct 19, 2022

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Oct 19, 2022

This PR updates the documentation:

  • re-generate the screenshots
  • add missing sample code and icons to the doc

It also removes the check of silx path in sphinx config, it is now the responsibility of the caller to set its environment correctly.

@t20100 t20100 added this to the 1.1.0 milestone Oct 19, 2022
@t20100 t20100 requested review from woutdenolf and vallsv October 19, 2022 09:45
woutdenolf
woutdenolf approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vallsv
Copy link
Contributor

vallsv commented Oct 19, 2022

You are about to remove the @pierrepaleo water mark!

@vallsv vallsv merged commit 882c65d into silx-kit:master Oct 19, 2022
@t20100 t20100 deleted the update-doc branch October 19, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutdenolf woutdenolf woutdenolf approved these changes

@vallsv vallsv Awaiting requested review from vallsv

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@t20100 @vallsv @woutdenolf