Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silx.gui.plot.profile: Handle disconnect exception #3692

Merged
merged 1 commit into from
Oct 12, 2022
Merged

silx.gui.plot.profile: Handle disconnect exception #3692

merged 1 commit into from
Oct 12, 2022

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Oct 11, 2022

This should fix issues regarding unconnected signal

closes #3691

@t20100 t20100 added this to the 1.1.0 milestone Oct 11, 2022
@t20100 t20100 requested a review from woutdenolf October 11, 2022 13:28
woutdenolf
woutdenolf approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@t20100 t20100 merged commit 4d777a0 into silx-kit:master Oct 12, 2022
@t20100 t20100 deleted the handle-disconnect-exception branch October 12, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutdenolf woutdenolf woutdenolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

TypeError in profile editor
2 participants
@t20100 @woutdenolf