silx.io.nxdata: Updated get_default to be more permissive and follow @default recursively
#3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added some tests and made it resilient to |
|
TestDataFileDialogInteraction.testClickOnBackToParentTool fails on mac. Is it related to the changes? |
|
No, there's quite a lot of random issue with tests relying on timings at the moment like interaction in widgets or a file to be created/deleted. I didn't looked at this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes behavior of
silx.io.nxdata.get_default.The search of
@defaultNXdatanow recursively follows@default.It also stop checking
NX_classalong the way (i.e.,NXroot/NXentry/NXdata) and only checks forNX_class="NXdata"to find theNXdatagroup.I'm wondering if the
silx.io.nxdatafunctions:is_group_with_default_NXdata,is_NXentry_with_default_NXdata,is_NXroot_with_default_NXdatathat were used byget_defaultare used anywhere (they're no longer used in silx), I'm tempted to deprecate them...It still needs a bit of testing.
closes #3605