Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFT: avoid creating opencl/cuda contexts when not needed #3587

Merged
merged 5 commits into from
Feb 15, 2022
Merged

FFT: avoid creating opencl/cuda contexts when not needed #3587

merged 5 commits into from
Feb 15, 2022

Conversation

pierrepaleo
Copy link
Contributor

(see #3439 discussion)

This PR fixes opencl/cuda contexts being created unnecessarily.

Changelog: FFT: avoid creating opencl/cuda contexts when not needed

@pierrepaleo pierrepaleo mentioned this pull request Jan 11, 2022
Closed
@kif
Copy link
Member

kif commented Jan 11, 2022

LGTM

t20100
t20100 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge it?

@pierrepaleo
Copy link
Contributor Author

Yes, thanks

@t20100
Copy link
Member

t20100 commented Jan 31, 2022

could you rebase so CI works better?

@pierrepaleo
Copy link
Contributor Author

Sorry missed the last answer. The PR was rebased on latest master.

@t20100 t20100 merged commit 0faf35f into master Feb 15, 2022
@t20100 t20100 deleted the fft_import branch February 15, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t20100 t20100 t20100 approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierrepaleo @kif @t20100