silx view: Added Windows installer generation #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. |
t20100
commented
Nov 5, 2021
|
CI fails after tests pass (see #3553) |
|
I've built the binary on a Windows 7 VM and installed it on another with Windows 10. Unfortunately, it doesn't work, and I get the following error: "Fatal error detected. Archive not found: C:\Program Files\silx\bootstrap." |
|
Installer built with CI is available here: https://gitlab.esrf.fr/silx/bob/silx/-/jobs/275225/artifacts/raw/artifacts/silx-1.0.0-a0-x64.exe |
|
Using the binary generated by the CI everything works as expected. |
|
btw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the config file and code to generate a Windows installer for silx view (silx as command line
is also embedded).
The way to handle 2 executable in the same bundle is also updated since pyinstaller fixed an issue on this. It still requires a small hack but it is much better now.
This is copied/adapted from crispy,many thanks to @mretegan!!!
This saved me a lot of time!