FIO file read support #3539
Merged
FIO file read support #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Thanks for the PR! |
t20100
reviewed
Oct 21, 2021
Co-authored-by: Thomas VINCENT <[email protected]>
Co-authored-by: Thomas VINCENT <[email protected]>
Co-authored-by: Thomas VINCENT <[email protected]>
…e on FioH5 init. Add fixed length str read for h5py < 3.0.
t20100
approved these changes
Nov 2, 2021
|
Great, I guess this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everybody,
as discussed in issue #3438 I have further improved my code, which allows silx.io to read FIO files generated by DESY beamlines.
This PR includes:
There are also small changes to the common silx.io packages, which allow the fio files to be opened with silx.io.open and silx convert.
While writing the code, I have encountered some issues with string datatypes.
In particular, there seems to be no matching datatype in silx for the h5py type "variable length strings" in 1d h5-like datasets. This is not really surprising since all data (in for example spech5) is internally stored as numpy arrays and those only support fixed length strings. My current solution is to read these data as python objects, which seems to work fine. But this might cause issues in the future. Is there a better solution?
Edit (after properly reading the h5py documentation ;) ):
The usage of the
'O'dtype is the recommended way of reading variable length strings for h5py as of version 3.0. So everything is fine.I have also added support for the old API (< 3.0) in 421f70f.
I hope that you are happy with my first PR.
Best regards,
Timo