Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports RGB and RGBA in ImageView #3487

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

vallsv
Copy link
Contributor

@vallsv vallsv commented Jun 11, 2021

This PR release constraints on setImage to allow to set RGB and RGBA images.

Few other places were fixed, like statusbar display, but not much.

Changelog:

  • Added support of RGB and RGBA images to ImageView

@vallsv vallsv requested a review from t20100 June 11, 2021 09:36
@vallsv
Copy link
Contributor Author

vallsv commented Jun 11, 2021

I think it is fine to back port it to 0.15, but it's up to you.

@vallsv vallsv force-pushed the support-rgb-in-imageview branch from ba038e2 to c1abab8 Compare June 11, 2021 09:42
Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions to support RGBA as float in [0,1] and catch malformed RGB images early.
Else LGTM, I don't see what this PR can break in current API except for the valueChanged signal when you load a RGB image, but that's a new feature so it's fine.

src/silx/gui/plot/ImageView.py Outdated Show resolved Hide resolved
src/silx/gui/plot/ImageView.py Outdated Show resolved Hide resolved
src/silx/gui/plot/ImageView.py Outdated Show resolved Hide resolved
src/silx/gui/plot/ImageView.py Outdated Show resolved Hide resolved
@t20100 t20100 merged commit 0484cd0 into silx-kit:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants