3451 doubleword #3472
Merged
3451 doubleword #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrepaleo
approved these changes
May 31, 2021
|
Looks good. CI fails on some platform with |
|
On Mon, 31 May 2021 01:29:46 -0700 Pierre Paleo ***@***.***> wrote:
Looks good. CI fails on some platform with
```
2021-05-31T08:26:05.3283670Z File "setup.py", line 612, in patch_extension
2021-05-31T08:26:05.3284390Z numpy_version = [int(i) for i in numpy.version.short_version.split(".", 2)[:2]]
2021-05-31T08:26:05.3285640Z AttributeError: module 'numpy.version' has no attribute 'short_version'
```
I'll come to ESRF to install the new mac so that we can debug. Mine is too old to be updated now.
|
|
Maybe related to https://pypi.org/project/numpy/1.21.0rc1/ released on the 24th of May? |
|
I confirm ... Able to reproduce the bug with numpy-RC |
|
Fixed upstream ... waiting for numpy 1.21rc2. |
|
LGTM, can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement over existing PR: just rename 3 functions