Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui][ImageStack] add an option to avoid reseting the plot each time #3373

Merged
merged 1 commit into from
Feb 10, 2021
Merged

[gui][ImageStack] add an option to avoid reseting the plot each time #3373

merged 1 commit into from
Feb 10, 2021

Conversation

payno
Copy link
Member

@payno payno commented Feb 10, 2021

No description provided.

@payno payno added this to the 0.15 milestone Feb 10, 2021
@t20100
Copy link
Member

t20100 commented Feb 10, 2021

A few comments:

  • Would be good to have a docstring for ImageStack.setResetZoom
  • Would be good to have a getter as well: isResetZoom
  • Alternative method name: is|setAutoResetZoom?
  • When calling set(Auto)ResetZoom(True), you might want to reset zoom at that time as well?

@payno payno force-pushed the reset_zoom_image_stack branch 2 times, most recently from c634c15 to efbe566 Compare February 10, 2021 13:41
@payno
Copy link
Member Author

payno commented Feb 10, 2021

Yes you are right others are named "is | setAutoResetZoom".
I also added the auto reset when set to True

@payno payno force-pushed the reset_zoom_image_stack branch from efbe566 to 4b31ff2 Compare February 10, 2021 14:01
@payno payno force-pushed the reset_zoom_image_stack branch from 4b31ff2 to 01a0ac4 Compare February 10, 2021 15:39
@t20100 t20100 merged commit 9cda58d into silx-kit:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
2 participants
@payno @t20100