silx.gui.plot.Stackview: Replaced setColormap autoscale argument by scaleColormapRangeToStack method
#3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's fine |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates the
autoscaleargument ofStackView.setColormapwhich triggers the scaling of the colormap to the whole stack whensetColormaporsetStackis called, and so it is NOT use the whole stack when in autoscale mode as on would expect.A
scaleColormapRangeToStackmethod is added to which sets the range of the colormap to that of the stack.This does not prevent adding a true autoscale to stack later.
If someone has a better idea to name the
scaleColormapRangeToStackmethod, I'd take it.To me it closes #2835