silx.gui.data: Make TextFormatter compatible with h5py>=3 #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, there is an issue with fixed length UTF-8 which does not get decoded, but it was already there before this PR. |
|
Looks better than the first patch. |
|
Added call of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this PR extends the
tools/create_h5_sample.pyto create more text datasets to test with.Then, it makes the
TextFormatterwork acrossh5py2 and 3.Finally it reverts changes made in PR #3240 about
test_textformatter.pyto test wht this PR provides.It looks to work fine in
silx viewfrom what I tested with both h5py 2.10 and 3.closes #3245