Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx view VDS and external data #3222

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Conversation

woutdenolf
Copy link
Contributor

@woutdenolf woutdenolf commented Oct 13, 2020

closes #3214

Add support for external data (virtual and raw, nothing to do with external links) to silx view:

  • add "Virtual" or "ExtRaw" to the Link column (added tests)
  • add "external sources" section to the table view (no tests for this)

Data generated with this script looks like this:
image

@woutdenolf woutdenolf changed the title WIP: silx view VDS and external data silx view VDS and external data Oct 14, 2020
@woutdenolf woutdenolf marked this pull request as ready for review October 14, 2020 09:54
@woutdenolf
Copy link
Contributor Author

woutdenolf commented Oct 14, 2020

@vallsv Not sure about the name ExtRaw in the Link column. It is external data in non-HDF5 files (raw binary format).

@vallsv
Copy link
Contributor

vallsv commented Oct 14, 2020

If you prefer you can add a tooltip, so what it is not anymore ambiguous.

Up to you.

@vallsv
Copy link
Contributor

vallsv commented Oct 14, 2020

To me it can be merge as it is. Let me know.

@woutdenolf
Copy link
Contributor Author

It's ready for me as well. ExtRaw is rarely used. We can add a tooltip later if requested.

@vallsv vallsv merged commit b08930f into silx-kit:master Oct 14, 2020
@vallsv
Copy link
Contributor

vallsv commented Oct 14, 2020

CI failure was about h5py string change. Nothing to do with this PR.

@woutdenolf
Copy link
Contributor Author

Forgot to add TestH5Item to the tests. I'll make a new PR for that.

@woutdenolf woutdenolf deleted the feature_3214 branch October 14, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

silx view: show virtual source info
2 participants