Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silx.gui: Fixed matplotlib 3.3.0rc1 deprecation warnings #3145

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Jul 1, 2020

This PR avoids deprecation warnings raised by matplotlib 3.3.0rc1 during tests.

closes #3144

@t20100 t20100 added this to the 0.14 milestone Jul 1, 2020
@vallsv
Copy link
Contributor

vallsv commented Jul 7, 2020

Was it deprecated for a long time?

        if _matplotlib_colormaps is not None:
            colormaps.update(_matplotlib_colormaps())
        elif _matplotlib_cm is not None:
            colormaps.update(_matplotlib_cm.cmap_d.keys())

Else it is maybe better to do that?

@t20100
Copy link
Member Author

t20100 commented Jul 7, 2020

Even without the deprecation, matplotlib.pyplot.colormaps is what should be used, it's been there for a very long while, see https://github.com/matplotlib/matplotlib/blame/master/lib/matplotlib/pyplot.py#L1874

@vallsv vallsv merged commit b862539 into silx-kit:master Jul 8, 2020
@vallsv
Copy link
Contributor

vallsv commented Jul 8, 2020

SOunds good then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plot] Matplotlib 3.3.0rc1 deprecation warnings
2 participants