silx.gui.colors: Added Colormap.get|setNaNColor to change color used for NaN
#3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colormap parameters
|
Looks good to me, except the NaN color should be saved in saveState/restoreState. I can do it if you like. |
|
I updated the store/restore methods. |
|
Well done. Very nice to check the v2 binary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaN values in images were displayed differentely with the matplotlib backend (transparent) and the opengl one (as lowest bound of the colormap).
This PR fixes this difference by making the OpenGL backend behave as the matplotlib one.
Furthermore, it adds
Colormap.get|setNaNColormethods to allow to change the color used for NaN and it supports it in bothPlotWidgetandplot3d.