Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed import of distutils #276

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Removed import of distutils #276

merged 2 commits into from
Sep 7, 2023

Conversation

t20100
Copy link
Member

@t20100 t20100 commented Sep 7, 2023

This PR aims at removing the import of distutils by using an approach proposed in pypa/setuptools#2806 (comment).

Imports of distutils as fallbacks for older versions of setuptools are kept for now.

related to #193

@t20100 t20100 added this to the Next release milestone Sep 7, 2023
@t20100 t20100 requested review from kif and vasole September 7, 2023 07:58
@t20100
Copy link
Member Author

t20100 commented Sep 7, 2023

Added wheel dependency to debian packaging that was added as requirement in PR #272

kif
kif approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@kif kif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kif kif merged commit cab208c into silx-kit:main Sep 7, 2023
6 checks passed
@t20100 t20100 deleted the remove-distutils branch September 12, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kif kif kif approved these changes

@vasole vasole Awaiting requested review from vasole

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@t20100 @kif