Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Expose lib/urls from silverstripe/admin #57

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 12, 2023

Exposes a new lib which was added in silverstripe/silverstripe-admin#1438
This is useful for joining URL paths together without caring if they have trailing/leading slashes, if there's a host already, etc.

NOTE

Once merged, this needs to be tagged as a new alpha and released on NPM, then any PRs which require this need to be updated with yarn upgrade @silverstripe/webpack-config.

Parent issue

@emteknetnz emteknetnz merged commit 4ebadcb into silverstripe:2 Jan 20, 2023
@emteknetnz emteknetnz deleted the pulls/2/expose-lib-urls branch January 20, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants